[ 
https://issues.apache.org/jira/browse/CASSANDRA-19556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844929#comment-17844929
 ] 

Stefan Miklosovic commented on CASSANDRA-19556:
-----------------------------------------------

[CASSANDRA-19556-5.0|https://github.com/instaclustr/cassandra/tree/CASSANDRA-19556-5.0]
{noformat} 
java11_pre-commit_tests                         
  ✓ j11_build                                        7m 58s
  ✓ j11_cqlsh_dtests_py311                           9m 57s
  ✓ j11_cqlsh_dtests_py311_vnode                     9m 36s
  ✓ j11_cqlsh_dtests_py38                            8m 52s
  ✓ j11_cqlsh_dtests_py38_vnode                      9m 52s
  ✓ j11_cqlshlib_cython_tests                       11m 25s
  ✓ j11_cqlshlib_tests                               9m 39s
  ✓ j11_dtests                                      33m 33s
  ✓ j11_dtests_latest                               36m 25s
  ✓ j11_dtests_vnode                                35m 29s
  ✓ j11_jvm_dtests                                  22m 39s
  ✓ j11_jvm_dtests_latest_vnode                     18m 37s
  ✓ j11_simulator_dtests                            10m 28s
  ✓ j11_unit_tests                                  15m 33s
  ✓ j11_unit_tests_repeat                           17m 36s
  ✓ j11_utests_latest                               17m 40s
  ✓ j11_utests_latest_repeat                        18m 10s
  ✓ j11_utests_oa                                   15m 54s
  ✓ j11_utests_oa_repeat                            17m 12s
  ✓ j11_utests_system_keyspace_directory_repeat     15m 18s
  ✓ j17_cqlsh_dtests_py311                           6m 20s
  ✓ j17_cqlsh_dtests_py311_vnode                     6m 24s
  ✓ j17_cqlsh_dtests_py38                            6m 15s
  ✓ j17_cqlsh_dtests_py38_vnode                      6m 20s
  ✓ j17_cqlshlib_cython_tests                        7m 31s
  ✓ j17_cqlshlib_tests                               6m 39s
  ✓ j17_dtests                                      32m 52s
  ✓ j17_dtests_latest                                33m 8s
  ✓ j17_dtests_vnode                                33m 13s
  ✓ j17_jvm_dtests                                  21m 57s
  ✓ j17_jvm_dtests_latest_vnode                      17m 5s
  ✓ j17_unit_tests                                  14m 28s
  ✓ j17_unit_tests_repeat                           13m 36s
  ✓ j17_utests_latest                                17m 3s
  ✓ j17_utests_latest_repeat                        13m 55s
  ✓ j17_utests_oa                                   19m 44s
  ✓ j17_utests_oa_repeat                            13m 18s
  ✕ j11_utests_system_keyspace_directory            15m 11s
      org.apache.cassandra.cql3.validation.operations.SelectTest 
testCreatingUDFWithSameNameAsBuiltin_PrefersCompatibleArgs
java11_separate_tests                            
{noformat}

[java11_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4298/workflows/efcf5f01-6b32-4ca8-af12-a47f21564e26]

testCreatingUDFWithSameNameAsBuiltin_PrefersCompatibleArgs is just a flake


> Guardrail to block DDL/DCL queries
> ----------------------------------
>
>                 Key: CASSANDRA-19556
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-19556
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Feature/Guardrails
>            Reporter: Yuqi Yan
>            Assignee: Yuqi Yan
>            Priority: Normal
>             Fix For: 5.0-rc, 5.x
>
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> Sometimes we want to block DDL/DCL queries to stop new schemas being created 
> or roles created. (e.g. when doing live-upgrade)
> For DDL guardrail current implementation won't block the query if it's no-op 
> (e.g. CREATE TABLE...IF NOT EXISTS, but table already exists, etc. The 
> guardrail check is added in apply() right after all the existence check)
> I don't have preference on either block every DDL query or check whether if 
> it's no-op here. Just we have some users always run CREATE..IF NOT EXISTS.. 
> at startup, which is no-op but will be blocked by this guardrail and failed 
> to start.
>  
> 4.1 PR: [https://github.com/apache/cassandra/pull/3248]
> trunk PR: [https://github.com/apache/cassandra/pull/3275]
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to