[
https://issues.apache.org/jira/browse/CASSANDRA-19556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848560#comment-17848560
]
Stefan Miklosovic edited comment on CASSANDRA-19556 at 5/22/24 11:00 AM:
-------------------------------------------------------------------------
That being said, I am curious if the patch for trunk might go in as is - it is
removing alter_table_enabled guardrail.
If that is not desirable, then shadowing it is the next option. That means I
would need to get alter_table_enabled back.
Is everybody OK with this? Otherwise I am all ears how to do this - that was my
whole point why I wanted to do it before 5.0.0 is out by removing the old one.
Or we just do what Sam suggests, we just remove this feature altogether and
replace it by a system property. That will work but it will not work while
cluster is up and people need to prevent schema modifications operationally.
was (Author: smiklosovic):
That being said, I am curious if the patch for trunk might go in as is - it is
removing alter_table_enabled guardrail.
If that is not desirable, then shadowing it is the next option. That means I
would need to get alter_table_enabled back.
Is everybody OK with this? Otherwise I am all ears how to do this - that was my
whole point why I wanted to do it before 5.0.0 is out by removing the old one.
> Add guardrail to block DDL/DCL queries and replace alter_table_enabled
> guardrail
> --------------------------------------------------------------------------------
>
> Key: CASSANDRA-19556
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19556
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/Guardrails
> Reporter: Yuqi Yan
> Assignee: Yuqi Yan
> Priority: Normal
> Fix For: 5.x
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Sometimes we want to block DDL/DCL queries to stop new schemas being created
> or roles created. (e.g. when doing live-upgrade)
> For DDL guardrail current implementation won't block the query if it's no-op
> (e.g. CREATE TABLE...IF NOT EXISTS, but table already exists, etc. The
> guardrail check is added in apply() right after all the existence check)
> I don't have preference on either block every DDL query or check whether if
> it's no-op here. Just we have some users always run CREATE..IF NOT EXISTS..
> at startup, which is no-op but will be blocked by this guardrail and failed
> to start.
>
> 4.1 PR: [https://github.com/apache/cassandra/pull/3248]
> trunk PR: [https://github.com/apache/cassandra/pull/3275]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
