[
https://issues.apache.org/jira/browse/CASSANDRA-11695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17906031#comment-17906031
]
Stefan Miklosovic commented on CASSANDRA-11695:
-----------------------------------------------
It does not have any purpose. When checking the old code before this commit,
that property is read only here (and some irrelavant statup checks). Simulation
tests do not exercise this code path at all so setting (running e.g.
ShortPaxosSimulationTest and setting a breakpoint into Daemon) which renders
"CASSANDRA_JMX_REMOTE_PORT.setString("");" completely useless.
Even it was for something, then it would fail here (2) because empty string is
not parse-able to an integer.
(1)
https://github.com/apache/cassandra/blob/54e46880690bd5effb31116986292c1bdc9e891e/src/java/org/apache/cassandra/service/CassandraDaemon.java#L176
(2)
https://github.com/apache/cassandra/blob/54e46880690bd5effb31116986292c1bdc9e891e/src/java/org/apache/cassandra/service/CassandraDaemon.java#L189
I can ninja this, before that I will run the CI once again.
> Move JMX connection config to cassandra.yaml
> --------------------------------------------
>
> Key: CASSANDRA-11695
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11695
> Project: Apache Cassandra
> Issue Type: Improvement
> Components: Local/Config
> Reporter: Sam Tunnicliffe
> Assignee: Stefan Miklosovic
> Priority: Low
> Labels: lhf
> Fix For: 5.1
>
> Time Spent: 6h 20m
> Remaining Estimate: 0h
>
> Since CASSANDRA-10091, we always construct the JMX connector server
> programatically, so we could move its configuration from cassandra-env to
> yaml.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
