[ 
https://issues.apache.org/jira/browse/CASSANDRA-11695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17902070#comment-17902070
 ] 

Maulin Vasavada commented on CASSANDRA-11695:
---------------------------------------------

Hi [~smiklosovic] I've read bit more about how nodetool sets up etc. Since 
nodetool is a client app in a sense, it can choose to derive JMX_PORT in anyway 
separate from the server's way. That is to say- as per your PR changes we could 
move the source of JMX_PORT to cassandra.yaml for the server itself. However, 
since other tools built on top of the opensource (e.g. `dsetool and dse advrep` 
[ref 
link|[https://docs.datastax.com/en/dse/5.1/securing/nodetool-ssl-setup.html])] 
might still depend on `cassandra-env.sh` and to keep that contract intact we 
could move [this 
line|https://github.com/apache/cassandra/pull/3708/files#diff-f7131d9a4f739662e81931739eff926bd82a3a856e9e8ed790ee1aca4458d98dR57]
 in your PR to `cassandra-env.sh` to initialize it always from 
`cassandra.yaml`. Let me know if this makes sense. We have to keep in mind that 
other ssl related config (like keystore,truststore etc) is assumed to be coming 
from `nodetool-ssl.properties` so we should not have any further dependency 
from how server derives the ssl config. In simple words, I feel that ONLY the 
`JMX_PORT` needs to be defined in `cassandra-env.sh` like I mentioned here and 
rest should be fine.

> Move JMX connection config to cassandra.yaml
> --------------------------------------------
>
>                 Key: CASSANDRA-11695
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11695
>             Project: Apache Cassandra
>          Issue Type: Improvement
>          Components: Local/Config
>            Reporter: Sam Tunnicliffe
>            Priority: Low
>              Labels: lhf
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> Since CASSANDRA-10091, we always construct the JMX connector server 
> programatically, so we could move its configuration from cassandra-env to 
> yaml.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to