[
https://issues.apache.org/jira/browse/CASSANDRA-20132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17921538#comment-17921538
]
Stefan Miklosovic commented on CASSANDRA-20132:
-----------------------------------------------
[CASSANDRA-20132-trunk|https://github.com/instaclustr/cassandra/tree/CASSANDRA-20132-trunk]
{noformat}
java17_pre-commit_tests
✓ j17_build 4m 16s
✓ j17_cqlsh_dtests_py311_vnode 7m 21s
✓ j17_cqlsh_dtests_py38 8m 52s
✓ j17_cqlsh_dtests_py38_vnode 7m 29s
✓ j17_cqlshlib_cython_tests 7m 55s
✓ j17_cqlshlib_tests 7m 10s
✓ j17_jvm_dtests_latest_vnode 17m 53s
✓ j17_unit_tests 15m 32s
✓ j17_unit_tests_repeat 4m 42s
✓ j17_utests_latest 15m 12s
✓ j17_utests_latest_repeat 6m 1s
✓ j17_utests_oa 18m 30s
✓ j17_utests_oa_repeat 5m 14s
✕ j17_cqlsh_dtests_py311 8m 46s
cqlsh_tests.test_cqlsh_copy.TestCqlshCopy
test_bulk_round_trip_with_timeouts
✕ j17_dtests 59m 8s
refresh_test.TestRefresh test_refresh_deadlock_startup
✕ j17_dtests_latest 42m 25s
read_repair_test.TestSpeculativeReadRepair test_failed_read_repair
read_repair_test.TestSpeculativeReadRepair test_normal_read_repair
read_repair_test.TestSpeculativeReadRepair test_quorum_requirement
read_repair_test.TestSpeculativeReadRepair
test_quorum_requirement_on_speculated_read
read_repair_test.TestSpeculativeReadRepair test_speculative_data_request
✕ j17_dtests_vnode 41m 36s
refresh_test.TestRefresh test_refresh_deadlock_startup
✕ j17_jvm_dtests 19m 27s
org.apache.cassandra.distributed.test.ReadSpeculationTest speculateTest
java17_separate_tests
java11_pre-commit_tests
✓ j11_build 7m 43s
✓ j11_cqlsh_dtests_py311_vnode 11m 14s
✓ j11_cqlsh_dtests_py38 7m 59s
✓ j11_cqlsh_dtests_py38_vnode 8m 6s
✓ j11_cqlshlib_cython_tests 10m 32s
✓ j11_cqlshlib_tests 9m 37s
✓ j11_dtests_vnode 47m 23s
✓ j11_jvm_dtests 24m 17s
✓ j11_jvm_dtests_latest_vnode 24m 44s
✓ j11_simulator_dtests 8m 38s
✓ j11_unit_tests_repeat 7m 28s
✓ j11_utests_latest 19m 45s
✓ j11_utests_latest_repeat 5m 49s
✓ j11_utests_oa 18m 9s
✓ j11_utests_oa_repeat 8m 0s
✓ j11_utests_system_keyspace_directory 15m 54s
✓ j11_utests_system_keyspace_directory_repeat 7m 45s
✓ j17_cqlsh_dtests_py311 6m 56s
✓ j17_cqlsh_dtests_py311_vnode 7m 39s
✓ j17_cqlsh_dtests_py38 7m 2s
✓ j17_cqlsh_dtests_py38_vnode 7m 32s
✓ j17_cqlshlib_cython_tests 8m 19s
✓ j17_cqlshlib_tests 6m 58s
✓ j17_dtests_vnode 42m 57s
✓ j17_jvm_dtests 18m 38s
✓ j17_jvm_dtests_latest_vnode 17m 7s
✓ j17_unit_tests 16m 58s
✓ j17_unit_tests_repeat 4m 29s
✓ j17_utests_latest 16m 12s
✓ j17_utests_latest_repeat 5m 21s
✓ j17_utests_oa 15m 53s
✓ j17_utests_oa_repeat 4m 46s
✕ j11_cqlsh_dtests_py311 8m 33s
cqlsh_tests.test_cqlsh_copy.TestCqlshCopy
test_bulk_round_trip_with_timeouts
✕ j11_dtests 1h 0m 20s
✕ j11_dtests_latest 43m 15s
read_repair_test.TestSpeculativeReadRepair test_failed_read_repair
read_repair_test.TestSpeculativeReadRepair test_normal_read_repair
read_repair_test.TestSpeculativeReadRepair
test_quorum_requirement_on_speculated_read
✕ j11_unit_tests 18m 43s
org.apache.cassandra.db.guardrails.GuardrailMaximumTimestampTest
testEnabledWarn
✕ j17_dtests 39m 55s
refresh_test.TestRefresh test_refresh_deadlock_startup
✕ j17_dtests_latest 42m 56s
read_repair_test.TestSpeculativeReadRepair test_normal_read_repair
read_repair_test.TestSpeculativeReadRepair test_quorum_requirement
read_repair_test.TestSpeculativeReadRepair
test_quorum_requirement_on_speculated_read
java11_separate_tests
{noformat}
[java17_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/5285/workflows/20d3f23b-d9e5-4130-8c28-d87682f919de]
[java11_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/5285/workflows/3040fe6e-b395-4453-b506-ee0a39e2c36e]
TestSpeculativeReadRepair is CASSANDRA-20194. Other are just flakes.
+1
> Add metric and tracing event for scanned purgeable tombstones
> -------------------------------------------------------------
>
> Key: CASSANDRA-20132
> URL: https://issues.apache.org/jira/browse/CASSANDRA-20132
> Project: Apache Cassandra
> Issue Type: Improvement
> Components: Local/Other
> Reporter: Dmitry Konstantinov
> Assignee: Dmitry Konstantinov
> Priority: Normal
> Fix For: 5.x
>
> Attachments: cpu_profile_select_cell.html, profile.yaml,
> trace_sample.txt
>
> Time Spent: 6h 50m
> Remaining Estimate: 0h
>
> Currently, Cassandra can read data from SSTables with tombstones and later
> drop them silently if the tombstones are older than gc_grace_seconds (aka
> purgeable tombstones). Such tombstones are not visible via
> readTombstoneHistogram metric, not reported in Cassandra logs if tombstone
> threshold is crossed and not mentioned in tracing events. As a result if a
> partition has a lot of purgeable tombstones we may have a slow read query
> without any signs why it is it slow. Example: [^trace_sample.txt]
> This suggested improvement adds:
> 1) a new metric which tracks number of such tombstones:
> PurgeableTombstoneScannedHistogram
> 2) a new tracing event: "Read {} purgeable tombstone cells" if number of such
> tombstones > 0
>
> Implementation notes: the logic of new withMetricsRecording iterator is an
> adjusted version of existing withMetricsRecording iterator
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
