[ 
https://issues.apache.org/jira/browse/CASSANDRA-20164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933995#comment-17933995
 ] 

Ariel Weisberg commented on CASSANDRA-20164:
--------------------------------------------

With the fresh construction method or update you can iterate the tree in 
{{minOrder}} or {{maxOrder}} but the current approach for {{add}} doesn't 
reorder existing intervals in the tree with the ones being added if they don't 
intersect the existing center.

So you can have on the left an interval with greater low bound than its 
predecessor. I'm not sure there is a traversal that will produce the 
{{minOrder}} at that point.

I think the most workable thing will be to create an updated array as part of 
add.

> support copyAndAddIntervals in IntervalTree for faster replaceFlushed View 
> update
> ---------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-20164
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-20164
>             Project: Apache Cassandra
>          Issue Type: Improvement
>          Components: Local/Memtable, Local/SSTable
>            Reporter: Yuqi Yan
>            Assignee: Yuqi Yan
>            Priority: Normal
>             Fix For: 4.1.x
>
>         Attachments: image-2024-12-23-18-33-28-490.png, 
> image-2024-12-23-18-37-11-939.png
>
>
> More details in CASSANDRA-20159.
>  
> With CASSANDRA-20159 and this patch (marked as new), compared to 
> cassandra-4.1 trunk (marked as trunk) we no longer see this slow finish time 
> for replaceFlushed.
> !image-2024-12-23-18-33-28-490.png|width=1209,height=392!
> These spikes and slowness are no longer observed under the same stress test
> !image-2024-12-23-18-37-11-939.png|width=1314,height=303!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to