[
https://issues.apache.org/jira/browse/CASSANALYTICS-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17986468#comment-17986468
]
Liu Cao commented on CASSANALYTICS-73:
--------------------------------------
Thx for working on this! Left the same thing on the PR:
I'm working on a S3CassandraDataLayer which extends PartitionedDataLayer, but
does not rely on sidecar and use the object storage uploaded SSTables. I have a
working version internally which at some point in the future can contribute to
https://issues.apache.org/jira/browse/CASSANALYTICS-42
This means in many code path i don't have a sidecar client. I would argue that
taking in a TableSizeProvider as input directly to {{Sizing.create}} makes more
sense in terms of abstraction? I might be biased but that will make providing a
tableSizeProvider easier
> Simplify SidecarTableSizeProvider
> ---------------------------------
>
> Key: CASSANALYTICS-73
> URL: https://issues.apache.org/jira/browse/CASSANALYTICS-73
> Project: Apache Cassandra Analytics
> Issue Type: Improvement
> Components: Reader
> Reporter: Francisco Guerrero
> Assignee: Francisco Guerrero
> Priority: Normal
> Fix For: 1.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> I have a small suggestion to simplify the recently added
> {{SidecarTableSizeProvider}} (added in CASSANALYTICS-36). This change will
> pass the port information directly without having to pass the entire client
> configuration object to the constructor.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
