[
https://issues.apache.org/jira/browse/CASSANDRA-20829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18014093#comment-18014093
]
Stefan Miklosovic commented on CASSANDRA-20829:
-----------------------------------------------
[CASSANDRA-20829-4.1|https://github.com/instaclustr/cassandra/tree/CASSANDRA-20829-4.1]
{noformat}
java11_pre-commit_tests
✓ j11_build 1m 58s
✓ j11_cqlsh_dtests_py311 5m 44s
✓ j11_cqlsh_dtests_py311_vnode 6m 42s
✓ j11_cqlshlib_cython_tests 11m 8s
✓ j11_cqlshlib_tests 7m 25s
✓ j11_dtests_vnode 41m 39s
✓ j11_jvm_dtests 18m 38s
✓ j11_jvm_dtests_vnode 12m 10s
✓ j11_unit_tests 10m 31s
✓ j11_unit_tests_repeat 32m 8s
✕ j11_cqlsh_dtests_py3 5m 42s
cql_tracing_test.TestCqlTracing test_tracing_simple
cql_tracing_test.TestCqlTracing test_tracing_unknown_impl
✕ j11_cqlsh_dtests_py38 5m 51s
cql_tracing_test.TestCqlTracing test_tracing_default_impl
✕ j11_cqlsh_dtests_py38_vnode 6m 1s
cql_tracing_test.TestCqlTracing test_tracing_unknown_impl
✕ j11_cqlsh_dtests_py3_vnode 6m 1s
cql_tracing_test.TestCqlTracing test_tracing_default_impl
✕ j11_dtests 55m 31s
refresh_test.TestRefresh test_refresh_deadlock_startup
{noformat}
I am not sure what's up with TestCqlTracing, that is hardly related to what we
do here. It does not fail in Jenkins.
[java11_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/5946/workflows/599c24f0-d47b-49d8-b76d-c9bdfb00fda1]
> Secondary index implementations do not integrate with IndexGCTransaction when
> compaction contains fully expired SSTables
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-20829
> URL: https://issues.apache.org/jira/browse/CASSANDRA-20829
> Project: Apache Cassandra
> Issue Type: Bug
> Components: Feature/2i Index, Local/Compaction, Local/Compaction/TWCS
> Reporter: Stefan Miklosovic
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 4.0.x, 4.1.x
>
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> There is a test (1) which ensures that when data are TTLed and compacted,
> IndexGCTransaction is aware of that and it will invoke Indexer.removeRow()
> method eventually.
> However, this is not working properly when we have fully expired SSTables,
> e.g. as the result of a table being on TWCS and having TTL on that.
> The reason is that in CompactionTask, we are filtering out fully expired ones
> (2). These then do not go to the compaction process and then they are not
> reacted on in listener() (3) which contains this logic (4). Eventually,
> onRowMerge in IndexGCTransaction will make the diff and in its commit
> indexer.removeRow(row); will notify 2i about its removal.
>
> This integration is missing and it is quite a big problem because if there
> are custom secondary index implementations the fact that SSTables were fully
> expired is not propagated to them which means that data are never removed
> from whatever backend they use.
> The solution is to go to the compaction with fully expired SSTables as well
> _but only if we detected that respective column family has some indexes_
>
> (1)
> [https://github.com/apache/cassandra/blob/cassandra-4.1/test/unit/org/apache/cassandra/index/CustomIndexTest.java#L583-L607]
> (2)
> [https://github.com/apache/cassandra/blob/cassandra-4.1/src/java/org/apache/cassandra/db/compaction/CompactionTask.java#L174]
> (3)
> [https://github.com/apache/cassandra/blob/cassandra-4.1/src/java/org/apache/cassandra/db/compaction/CompactionIterator.java#L130]
> (4)
> [https://github.com/apache/cassandra/blob/cassandra-4.1/src/java/org/apache/cassandra/db/compaction/CompactionIterator.java#L235-L252]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
