[
https://issues.apache.org/jira/browse/CASSANDRA-20829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18014155#comment-18014155
]
Stefan Miklosovic commented on CASSANDRA-20829:
-----------------------------------------------
[CASSANDRA-20829-5.0|https://github.com/instaclustr/cassandra/tree/CASSANDRA-20829-5.0]
{noformat}
java17_pre-commit_tests
✓ j17_build 5m 44s
✓ j17_cqlsh_dtests_py311 6m 5s
✓ j17_cqlsh_dtests_py311_vnode 6m 38s
✓ j17_cqlsh_dtests_py38 6m 17s
✓ j17_cqlsh_dtests_py38_vnode 6m 3s
✓ j17_cqlshlib_cython_tests 10m 25s
✓ j17_cqlshlib_tests 6m 55s
✓ j17_dtests_latest 40m 6s
✓ j17_dtests_vnode 40m 46s
✓ j17_jvm_dtests 19m 45s
✓ j17_jvm_dtests_latest_vnode 19m 58s
✓ j17_unit_tests 14m 14s
✓ j17_unit_tests_repeat 33m 45s
✓ j17_utests_latest 16m 29s
✓ j17_utests_oa 15m 43s
✓ j17_utests_oa_repeat 33m 35s
✕ j17_dtests 36m 34s
refresh_test.TestRefresh test_refresh_deadlock_startup
✕ j17_utests_latest_repeat 32m 19s
org.apache.cassandra.index.CustomIndexTest testFailing2iFlush <-
multiplexer discovered, not related though
{noformat}
[java17_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/5948/workflows/31c92686-74b0-495a-a1c1-0b5b5f93920e]
> Secondary index implementations do not integrate with IndexGCTransaction when
> compaction contains fully expired SSTables
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-20829
> URL: https://issues.apache.org/jira/browse/CASSANDRA-20829
> Project: Apache Cassandra
> Issue Type: Bug
> Components: Feature/2i Index, Local/Compaction, Local/Compaction/TWCS
> Reporter: Stefan Miklosovic
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 4.0.x, 4.1.x, 5.0.x, 5.x
>
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> There is a test (1) which ensures that when data are TTLed and compacted,
> IndexGCTransaction is aware of that and it will invoke Indexer.removeRow()
> method eventually.
> However, this is not working properly when we have fully expired SSTables,
> e.g. as the result of a table being on TWCS and having TTL on that.
> The reason is that in CompactionTask, we are filtering out fully expired ones
> (2). These then do not go to the compaction process and then they are not
> reacted on in listener() (3) which contains this logic (4). Eventually,
> onRowMerge in IndexGCTransaction will make the diff and in its commit
> indexer.removeRow(row); will notify 2i about its removal.
>
> This integration is missing and it is quite a big problem because if there
> are custom secondary index implementations the fact that SSTables were fully
> expired is not propagated to them which means that data are never removed
> from whatever backend they use.
> The solution is to go to the compaction with fully expired SSTables as well
> _but only if we detected that respective column family has some indexes_
>
> (1)
> [https://github.com/apache/cassandra/blob/cassandra-4.1/test/unit/org/apache/cassandra/index/CustomIndexTest.java#L583-L607]
> (2)
> [https://github.com/apache/cassandra/blob/cassandra-4.1/src/java/org/apache/cassandra/db/compaction/CompactionTask.java#L174]
> (3)
> [https://github.com/apache/cassandra/blob/cassandra-4.1/src/java/org/apache/cassandra/db/compaction/CompactionIterator.java#L130]
> (4)
> [https://github.com/apache/cassandra/blob/cassandra-4.1/src/java/org/apache/cassandra/db/compaction/CompactionIterator.java#L235-L252]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
