lukasz-antoniak commented on code in PR #162:
URL:
https://github.com/apache/cassandra-analytics/pull/162#discussion_r2614308798
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/SortedSSTableWriter.java:
##########
@@ -63,6 +63,21 @@
* entire partition, i.e. repartitionAndSortWithinPartitions. By doing so, it
eliminates the nice property of the
* output sstable being globally sorted and non-overlapping.
* Unless you can think of a better use case, we should stick with this
SortedSSTableWriter
+ * <br>
+ * <p>Threading Model:</p>
+ * This class has limited thread-safety guarantees:
+ * <ul>
+ * <li>{@link #addRow(BigInteger, Map)} and {@link
#close(BulkWriterContext)} MUST be called from the same thread
Review Comment:
`addRow` method cannot be easily made thread safe because down the line
`CQLSStableWriter` is not. Shall we annotate `SSTableWriterImplementation` as
`@NotThreadSafe`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
