This is an automated email from the ASF dual-hosted git repository.

smiklosovic pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 3c69bd2367 ninja: fix tests after CASSANDRA-21074 landed
3c69bd2367 is described below

commit 3c69bd23673caa40b22f3500a3e3eecabc25c8e5
Author: Stefan Miklosovic <[email protected]>
AuthorDate: Mon Dec 22 10:32:10 2025 +0100

    ninja: fix tests after CASSANDRA-21074 landed
---
 .../org/apache/cassandra/io/compress/CompressionMetadataTest.java  | 7 +++++--
 .../apache/cassandra/io/compress/ZstdDictionaryCompressorTest.java | 1 +
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git 
a/test/unit/org/apache/cassandra/io/compress/CompressionMetadataTest.java 
b/test/unit/org/apache/cassandra/io/compress/CompressionMetadataTest.java
index 801a07c151..937fdbf7ea 100644
--- a/test/unit/org/apache/cassandra/io/compress/CompressionMetadataTest.java
+++ b/test/unit/org/apache/cassandra/io/compress/CompressionMetadataTest.java
@@ -101,9 +101,10 @@ public class CompressionMetadataTest
         byte[] dictBytes = "sample dictionary data for compression".getBytes();
         ZstdCompressionDictionary dictionary = new 
ZstdCompressionDictionary(dictId, dictBytes);
 
-        assertThat(dictionary.selfRef().globalCount()).isOne();
+        assertThat(dictionary.selfRef()).isNull();
         CompressionDictionaryCache cache = new CompressionDictionaryCache();
         cache.add(dictionary);
+        assertThat(dictionary.selfRef().globalCount()).isOne();
 
         // Verify dictionary is in cache
         CompressionDictionary cachedDict = cache.get(dictId);
@@ -187,10 +188,12 @@ public class CompressionMetadataTest
         byte[] dictBytes = "shared dictionary data".getBytes();
         ZstdCompressionDictionary dictionary = new 
ZstdCompressionDictionary(dictId, dictBytes);
 
-        assertThat(dictionary.selfRef().globalCount()).isOne();
+        assertThat(dictionary.selfRef()).isNull();
         CompressionDictionaryCache cache = new CompressionDictionaryCache();
         cache.add(dictionary);
 
+        assertThat(dictionary.selfRef().globalCount()).isOne();
+
         // Create multiple CompressionMetadata instances (simulating multiple 
SSTables)
         Memory memory1 = Memory.allocate(100);
         CompressionMetadata metadata1 = new CompressionMetadata(
diff --git 
a/test/unit/org/apache/cassandra/io/compress/ZstdDictionaryCompressorTest.java 
b/test/unit/org/apache/cassandra/io/compress/ZstdDictionaryCompressorTest.java
index ef5e3d11d8..c56a03dd77 100644
--- 
a/test/unit/org/apache/cassandra/io/compress/ZstdDictionaryCompressorTest.java
+++ 
b/test/unit/org/apache/cassandra/io/compress/ZstdDictionaryCompressorTest.java
@@ -281,6 +281,7 @@ public class ZstdDictionaryCompressorTest
     {
         ZstdDictionaryCompressor.invalidateCache();
         ZstdCompressionDictionary closedDict = createTestDictionary();
+        closedDict.initRefLazily();
         closedDict.close();
 
         // This should throw IllegalStateException


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to