frankgh commented on code in PR #172:
URL:
https://github.com/apache/cassandra-analytics/pull/172#discussion_r2843792037
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/TableSchema.java:
##########
@@ -307,4 +311,44 @@ private static List<Integer>
getKeyFieldPositions(StructType dfSchema,
.map(dfFieldNames::indexOf)
.collect(Collectors.toList());
}
+
+ private static void validateUserAddedColumns(String
lowestCassandraVersion, boolean quoteIdentifiers,
+ TTLOption ttlOption,
TimestampOption timestampOption)
+ {
+ CassandraBridge bridge =
CassandraBridgeFactory.get(lowestCassandraVersion);
+ if (!quoteIdentifiers)
+ {
Review Comment:
NIT avoid getting an instance of the bridge when it's not needed
```suggestion
if (!quoteIdentifiers)
{
CassandraBridge bridge =
CassandraBridgeFactory.get(lowestCassandraVersion);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
