lukasz-antoniak commented on code in PR #193:
URL: 
https://github.com/apache/cassandra-analytics/pull/193#discussion_r3085115036


##########
cassandra-analytics-common/src/main/java/org/apache/cassandra/spark/utils/streaming/BufferingInputStream.java:
##########


Review Comment:
   @skoppu22, I take it back. This was actually a root cause of my issue! I was 
always considering +1 due to condition:
   ```
   public boolean isFinished()
   {
       return bytesWritten() >= source.size();
   }
   ```
   I got confused with `bytesWritten()` returning _position-like_ index. My 
bad, of course you and Yifan were right.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to