lukasz-antoniak commented on code in PR #193: URL: https://github.com/apache/cassandra-analytics/pull/193#discussion_r3065072974
########## cassandra-analytics-common/src/main/java/org/apache/cassandra/spark/utils/streaming/BufferingInputStream.java: ########## Review Comment: > For example, if position is 50, does it mean BufferingInputStream should start reading from the offset 50? Correct, and `rangeStart = position`. `bytesRead` and `bytesWritten` should be 51 in this case. Count of bytes written and read is 1-based. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
