Copilot commented on code in PR #464:
URL:
https://github.com/apache/cassandra-nodejs-driver/pull/464#discussion_r3352497304
##########
package.json:
##########
@@ -20,11 +20,11 @@
"license": "Apache-2.0",
"types": "./index.d.ts",
"dependencies": {
- "@types/node": "^20.14.8",
"adm-zip": "~0.5.10",
"long": "~5.2.3"
},
"devDependencies": {
+ "@types/node": "^20.14.8",
"chai": "~4.3.8",
Review Comment:
`package-lock.json` still lists `@types/node` under top-level
`dependencies`. With this change, `npm ci` will fail because the lockfile is
out of sync with `package.json`. Regenerate and commit the updated lockfile so
`@types/node` is marked as a dev dependency there as well.
##########
package.json:
##########
@@ -20,11 +20,11 @@
"license": "Apache-2.0",
"types": "./index.d.ts",
"dependencies": {
- "@types/node": "^20.14.8",
"adm-zip": "~0.5.10",
"long": "~5.2.3"
},
"devDependencies": {
+ "@types/node": "^20.14.8",
"chai": "~4.3.8",
"kerberos": "^2.2.2",
"mocha": "~10.8.2",
Review Comment:
This package publishes `.d.ts` files that reference Node.js types/modules
(for example `Buffer` and imports from `events`/`tls`/`url` in `index.d.ts`).
Moving `@types/node` to only `devDependencies` can break TypeScript consumers
that don't already have `@types/node` installed, because they won't get it
transitively.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
