SiyaoIsHiding commented on code in PR #464:
URL:
https://github.com/apache/cassandra-nodejs-driver/pull/464#discussion_r3360022092
##########
package.json:
##########
@@ -20,11 +20,11 @@
"license": "Apache-2.0",
"types": "./index.d.ts",
"dependencies": {
- "@types/node": "^20.14.8",
"adm-zip": "~0.5.10",
"long": "~5.2.3"
},
"devDependencies": {
+ "@types/node": "^20.14.8",
"chai": "~4.3.8",
"kerberos": "^2.2.2",
"mocha": "~10.8.2",
Review Comment:
This is essentially independent from the TypeScript migration.
This is only removing a dependency that users won't use, and such move won't
break `trunk`.
I think we should treat it just like any other tickets, instead of a part of
the TypeScript migration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
