skoppu22 commented on code in PR #214:
URL:
https://github.com/apache/cassandra-analytics/pull/214#discussion_r3436199692
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraDirectDataTransportContext.java:
##########
@@ -71,7 +82,11 @@ public DirectDataTransferApi dataTransferApi()
// only invoke in constructor
protected DirectDataTransferApi createDirectDataTransferApi()
{
- CassandraBridge bridge =
CassandraBridgeFactory.get(clusterInfo.getLowestCassandraVersion());
- return new SidecarDataTransferApi(clusterInfo.getCassandraContext(),
bridge, jobInfo);
+ return new SidecarDataTransferApi(clusterInfo.getCassandraContext(),
bridge(), jobInfo);
+ }
+
+ private CassandraBridge bridge()
Review Comment:
[minor] Code still has a new bridge() function. Please use writerContext's
bridge function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
