skoppu22 commented on code in PR #214:
URL:
https://github.com/apache/cassandra-analytics/pull/214#discussion_r3372722119
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraDirectDataTransportContext.java:
##########
@@ -46,13 +46,24 @@ public CassandraDirectDataTransportContext(@NotNull
BulkWriterContext bulkWriter
}
@Override
- public DirectStreamSession createStreamSession(BulkWriterContext
writerContext,
- String sessionId,
- SortedSSTableWriter
sstableWriter,
- Range<BigInteger> range,
-
ReplicaAwareFailureHandler<RingInstance> failureHandler,
- ExecutorService
executorService)
+ public StreamSession<TransportContext.DirectDataBulkWriterContext>
createStreamSession(
+ BulkWriterContext writerContext,
+ String sessionId,
+ SortedSSTableWriter sstableWriter,
+ Range<BigInteger> range,
+ ReplicaAwareFailureHandler<RingInstance> failureHandler,
+ ExecutorService executorService)
{
+ if (bridge().isTracked(clusterInfo.getReplicationType()))
+ {
+ return new TrackedDirectStreamSession(writerContext,
Review Comment:
For any new feature, we should either develop them in a feature branch or
disable it under a feature flag until it is complete and stable. For example,
mutation tracking feature in C* is in a feature branch.
Especially in this PR, we are introducing an incomplete feature to the
upstream. So having a feature flag is very important to ensure existing use
cases are not broken by any chance with our new code inadvertently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
