skoppu22 commented on code in PR #169:
URL: 
https://github.com/apache/cassandra-analytics/pull/169#discussion_r3475698620


##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraClusterInfo.java:
##########
@@ -447,22 +413,35 @@ private TokenRangeMapping<RingInstance> 
getTokenRangeReplicasFromSidecar()
                                         metadata -> new RingInstance(metadata, 
clusterId()));
     }
 
-    public String getVersionFromFeature()

Review Comment:
   With bridge determination feature getLowestCassandraVersion is only used for 
logging in the driver. Executors doesn't need it. If I remember correctly 
(opened PR more than a month ago, might have forgotten a bit), I might have 
modified getLowestCassandraVersion as one time call as not needed on executors. 
Let me try to recollect and restore it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to