skoppu22 commented on code in PR #169:
URL:
https://github.com/apache/cassandra-analytics/pull/169#discussion_r3460113952
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/data/CassandraDataLayer.java:
##########
@@ -272,7 +278,11 @@ private int initBulkReader(@NotNull ClientConfig options)
throws ExecutionExcept
NodeSettings nodeSettings = sidecar.nodeSettings().get();
String cassandraVersion =
getEffectiveCassandraVersionForRead(clusterConfig, nodeSettings);
Partitioner partitioner = Partitioner.from(nodeSettings.partitioner());
- bridge = CassandraBridgeFactory.get(cassandraVersion);
+
+ // Initialize SSTable versions and bridge version
+ CassandraVersion bridgeVersion =
initializeSSTableVersionsAndBridgeVersion(cassandraVersion);
+ bridge = CassandraBridgeFactory.get(bridgeVersion);
Review Comment:
Write had log message in the caller. Now removed that and added comment
determineBridgeVersionForWrite. Also made log messages in
determineBridgeVersionForRead and determineBridgeVersionForWrite as info as it
gets printed only once in driver and helps in debugging.
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/data/CassandraDataLayer.java:
##########
@@ -272,7 +278,11 @@ private int initBulkReader(@NotNull ClientConfig options)
throws ExecutionExcept
NodeSettings nodeSettings = sidecar.nodeSettings().get();
String cassandraVersion =
getEffectiveCassandraVersionForRead(clusterConfig, nodeSettings);
Partitioner partitioner = Partitioner.from(nodeSettings.partitioner());
- bridge = CassandraBridgeFactory.get(cassandraVersion);
+
+ // Initialize SSTable versions and bridge version
+ CassandraVersion bridgeVersion =
initializeSSTableVersionsAndBridgeVersion(cassandraVersion);
+ bridge = CassandraBridgeFactory.get(bridgeVersion);
Review Comment:
Write had log message in the caller. Now removed that and added comment in
determineBridgeVersionForWrite. Also made log messages in
determineBridgeVersionForRead and determineBridgeVersionForWrite as info as it
gets printed only once in driver and helps in debugging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
