skoppu22 commented on code in PR #223:
URL:
https://github.com/apache/cassandra-analytics/pull/223#discussion_r3720242914
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/BulkSparkConf.java:
##########
@@ -276,6 +278,11 @@ public BulkSparkConf(SparkConf conf, Map<String, String>
options, @Nullable Logg
this.configuredJobId = MapUtils.getOrDefault(options,
WriterOptions.JOB_ID.name(), null);
this.coordinatedWriteConfJson = MapUtils.getOrDefault(options,
WriterOptions.COORDINATED_WRITE_CONFIG.name(), null);
this.coordinatedWriteConf =
buildCoordinatedWriteConf(dataTransportInfo.getTransport(), logger);
+ if (this.sidecarBehindLoadBalancer && this.coordinatedWriteConf ==
null && logger != null)
+ {
+ logger.warn("{} is set but {} is not configured; the flag is only
honored for coordinated writes and will be ignored on the single-cluster path.",
Review Comment:
I would recommend making LB handling as generic framework and invoke it from
both coordinated and single cluster case, then we will have uniformity and
support for both cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
