bbotella commented on code in PR #247:
URL:
https://github.com/apache/cassandra-analytics/pull/247#discussion_r4080420259
##########
cassandra-six-zero-bridge/src/main/java/org/apache/cassandra/db/DbUtils.java:
##########
@@ -40,13 +40,14 @@ public static DeletionTime deletionTime(long
markedForDeleteAt, long localDeleti
}
/**
- * Cassandra 6.0 drops the {@code nowInSeconds} argument of {@code
LivenessInfo.create}, which 5.0
- * discarded. The parameter stays here so that callers are the same across
bridge versions.
+ * Cassandra 6.0 drops the {@code nowInSeconds} argument of {@code
LivenessInfo.create}, but the
+ * cep-45-mutation-tracking branch is yet to be updated with this change,
so the two-argument form is still the only
+ * one on the classpath. Switch to {@code create(timestamp)} once the pin
moves past that change.
Review Comment:
Can we add a Jira for this?
##########
cassandra-six-zero/build.gradle:
##########
@@ -24,7 +24,36 @@ plugins {
id('com.github.johnrengelman.shadow')
}
+// A cassandra-all built by scripts/install-cassandra-all-local.sh is served
only by the local
+// repository under dependencies/, not by Maven Central. Declaring that
exclusively keeps the
+// resolution independent of repository order, and avoids asking Central for a
version it cannot have.
+def locallyBuiltCassandraAll =
file("${rootProject.ext.dependencyLocation}org/apache/cassandra" +
+
"/cassandra-all/${cassandra60Version}/cassandra-all-${cassandra60Version}.pom")
+if (locallyBuiltCassandraAll.exists()) {
+ println("Using locally built cassandra-all ${cassandra60Version} from
${rootProject.ext.dependencyLocation}")
+ repositories {
+ exclusiveContent {
+ forRepository {
+ mavenLocal {
+ name = 'localCassandraBuild'
+ url = uri(rootProject.ext.dependencyLocation)
+ }
+ }
+ filter {
+ includeVersion('org.apache.cassandra', 'cassandra-all',
"${cassandra60Version}")
+ includeVersion('org.apache.cassandra', 'cassandra-parent',
"${cassandra60Version}")
+ // cassandra-all depends on cassandra-accord, which the accord
submodule publishes from the
+ // same commit and under the same version, so it is only in
the local repository.
+ includeVersion('org.apache.cassandra', 'cassandra-accord',
"${cassandra60Version}")
+ }
+ }
+ }
+}
+
dependencies {
+ // cassandra60Version points to a commit from cep-45 branch rather than a
Maven Central release, because the
+ // SSTables this bridge writes have to be readable by the cluster under
test. When that version cannot be resolved,
Review Comment:
Add Jira?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
