yifan-c commented on code in PR #226:
URL:
https://github.com/apache/cassandra-analytics/pull/226#discussion_r4235388745
##########
cassandra-analytics-common/src/main/java/org/apache/cassandra/spark/data/QualifiedTableName.java:
##########
@@ -65,6 +65,14 @@ public String keyspace()
return keyspace;
}
+ /**
+ * @return the keyspace name, quoted with double quotes when {@code
quoteIdentifiers} is set
+ */
+ public String maybeQuotedKeyspace()
+ {
+ return maybeQuote(keyspace);
+ }
+
Review Comment:
Instead of adding the `maybeQuotedX` methods, could you please use the
helper
`org.apache.cassandra.bridge.CassandraBridgeFactory#maybeQuotedIdentifier` for
code consistency? You can find code example in
`org.apache.cassandra.spark.bulkwriter.SidecarDataTransferApi`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
