bianca-stanciu29 commented on code in PR #226:
URL:
https://github.com/apache/cassandra-analytics/pull/226#discussion_r4247574967
##########
cassandra-analytics-common/src/main/java/org/apache/cassandra/spark/data/QualifiedTableName.java:
##########
@@ -65,6 +65,14 @@ public String keyspace()
return keyspace;
}
+ /**
+ * @return the keyspace name, quoted with double quotes when {@code
quoteIdentifiers} is set
+ */
+ public String maybeQuotedKeyspace()
+ {
+ return maybeQuote(keyspace);
+ }
+
Review Comment:
Done, thanks for pointing me to the helper. I removed
`maybeQuotedKeyspace()` and `maybeQuotedTable()`, so `QualifiedTableName` is
unchanged from trunk.
`CloudStorageDataTransferApiImpl` now takes a `CassandraBridge`, and
`CloudStorageDataTransferApiFactory` passes
`CassandraBridgeFactory.get(clusterInfo.getBridgeVersion())`, so each cluster
in a coordinated write gets its own bridge. All restore requests,
single-cluster and coordinated, now use `maybeQuotedIdentifier(bridge,
qt.quoteIdentifiers(), ...)` as in `SidecarDataTransferApi`. As on the direct
path, names that don't need quoting (e.g. all lower-case) are sent as-is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
