[
https://issues.apache.org/jira/browse/CASSANDRA-2392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190776#comment-13190776
]
Pavel Yaskevich commented on CASSANDRA-2392:
--------------------------------------------
Also changes shown below are odd because the same behavior you get by keeping
code the same - it will just throw an exception somewhere in try block, run
code in finally block and never get to the indexSummary.complete() and
{i,d}builder.complete(String) methods which are no-op in that case. Btw,
indexSummary.complete() can be moved out from the try block because it doesn't
throw IOException and no-op if code above it does but that is not a big deal
anyway.
{noformat}
+ catch (IOException ex)
+ {
+ exception = true;
+ throw ex;
}
finally
{
+ // close the file first.
FileUtils.closeQuietly(input);
+ if (!exception)
+ {
+ // finalize the load.
+ indexSummary.complete();
+ // finalize the state of the reader
+ ifile =
ibuilder.complete(descriptor.filenameFor(Component.PRIMARY_INDEX));
+ dfile =
dbuilder.complete(descriptor.filenameFor(Component.DATA));
+ }
}
{noformat}
> Saving IndexSummaries to disk
> -----------------------------
>
> Key: CASSANDRA-2392
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2392
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Chris Goffinet
> Assignee: Vijay
> Priority: Minor
> Fix For: 1.1
>
> Attachments: 0001-re-factor-first-and-last.patch,
> 0001-save-summaries-to-disk.patch, 0002-save-summaries-to-disk-v2.patch,
> 0002-save-summaries-to-disk-v3.patch, 0002-save-summaries-to-disk.patch
>
>
> For nodes with millions of keys, doing rolling restarts that take over 10
> minutes per node can be painful if you have 100 node cluster. All of our time
> is spent on doing index summary computations on startup. It would be great if
> we could save those to disk as well. Our indexes are quite large.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
