[
https://issues.apache.org/jira/browse/CASSANDRA-2392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190784#comment-13190784
]
Vijay commented on CASSANDRA-2392:
----------------------------------
>>> indexSummary.complete() can be moved out from the try block because it
>>> doesn't throw IOException
Well thats for the following...
if (!recreatebloom && !cacheLoading && loadSummaries)
return;
We still need to complete the indexes and builders even though you dont go
through all the code in try.
>>> is not a guaranteed thing which means that IndexSummary.last has a
>>> different semantics
Not sure if it can have different semantics, but i will remove the refactor not
a big deal.
>>> Summaries methods are leaking file descriptors
I dont think in either case we leak descriptors it is in the finally block
already and all we are planning to save is a variable assignment and i will do
that not a big deal.
> Saving IndexSummaries to disk
> -----------------------------
>
> Key: CASSANDRA-2392
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2392
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Chris Goffinet
> Assignee: Vijay
> Priority: Minor
> Fix For: 1.1
>
> Attachments: 0001-re-factor-first-and-last.patch,
> 0001-save-summaries-to-disk.patch, 0002-save-summaries-to-disk-v2.patch,
> 0002-save-summaries-to-disk-v3.patch, 0002-save-summaries-to-disk.patch
>
>
> For nodes with millions of keys, doing rolling restarts that take over 10
> minutes per node can be painful if you have 100 node cluster. All of our time
> is spent on doing index summary computations on startup. It would be great if
> we could save those to disk as well. Our indexes are quite large.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
