[ 
https://issues.apache.org/jira/browse/CASSANDRA-4233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sylvain Lebresne updated CASSANDRA-4233:
----------------------------------------

    Attachment: 0001-Make-sure-Leveled-compaction-always-use-the-right-min-.txt

This was kind of a test problem, though this is kind of a bug.

The main problem is that LeveledCompaction should never get a 
maxCompactionThreshold < Integer.MAX_VALUE, otherwise it ends up not compaction 
what it should and this screw up the levels. However, the way we try to ensure 
that is by overriding the maxCompactionThreshold in LeveledCompactionStrategy 
constructor. This is however dangerous because it means that if anyone change 
the threshold afterward, it will break. And sure enough, that is what happens 
with CompactionsTest.

So attaching a patch that change the code to ensure this doesn't happen. To a 
large extend this patch is a hack and in the long run, we should refactor all 
this to move the min/max compaction threshold inside SizeTieredCompaction, 
where they belong. This is however a bigger refactor than I want to do on the 
1.1 branch as currently the thresholds are used to deactivate automatic 
compaction and whatnot.
                
> overlapping sstables in leveled compaction strategy
> ---------------------------------------------------
>
>                 Key: CASSANDRA-4233
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4233
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 1.1.0
>            Reporter: Jonathan Ellis
>             Fix For: 1.1.1
>
>         Attachments: 
> 0001-Make-sure-Leveled-compaction-always-use-the-right-min-.txt, 
> 4233-assert.txt, system.log.bz2
>
>
> CASSANDRA-4142 introduces test failures, that are caused by overlapping 
> tables within a level, which Shouldn't Happen.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to