[ 
https://issues.apache.org/jira/browse/CASSANDRA-4233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13277968#comment-13277968
 ] 

Sylvain Lebresne commented on CASSANDRA-4233:
---------------------------------------------

I'd submit that my version was giving a slightly better feedback through JMX 
but I guess that's not a big deal.

But other than that, the definition of isCompactionDisabled so far has been to 
disallow automatic compaction, but forced compaction ("maximal" ones) was still 
allowed. v2 change that for LCS. I'll note that disabling compaction was 
respected for background tasks by LCS by the fact that 
DataTracker.maxCompacting was skipping compaction when maxCompactionThreshold 
is 0, but allowed for maximal tasks since the maxCompactionThreshold is 
overriden in compactionManager in that case. I don't know if it's a big deal 
though (I suspect some tests would fail if run with LCS because they rely on 
that) but wanted to mention it.
                
> overlapping sstables in leveled compaction strategy
> ---------------------------------------------------
>
>                 Key: CASSANDRA-4233
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4233
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 1.1.0
>            Reporter: Jonathan Ellis
>            Assignee: Sylvain Lebresne
>             Fix For: 1.1.1
>
>         Attachments: 
> 0001-Make-sure-Leveled-compaction-always-use-the-right-min-.txt, 
> 4233-assert.txt, 4233-v2.txt, 4233-v3.txt, system.log.bz2
>
>
> CASSANDRA-4142 introduces test failures, that are caused by overlapping 
> tables within a level, which Shouldn't Happen.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to