[
https://issues.apache.org/jira/browse/CASSANDRA-4436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13420930#comment-13420930
]
Jonathan Ellis commented on CASSANDRA-4436:
-------------------------------------------
Looks like skipCompacted in Directories.SSTableLister can be removed (since we
scrubDataDirectories on startup and no new compacted components will be
created).
Using a List means we can add an ancestor multiple times. Suggest using a Set
instead.
Nits:
- would prefer Ancestor to LiveAncestor, since we only check liveness at
creation time, so "Live" is misleading when iterating over them later.
- the deleting code feels more at home in CFS constructor than
addInitialSSTables.
- tracker parameter is unused now in SSTR.open
> Counters in columns don't preserve correct values after cluster restart
> -----------------------------------------------------------------------
>
> Key: CASSANDRA-4436
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4436
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.0.10
> Reporter: Peter Velas
> Assignee: Sylvain Lebresne
> Fix For: 1.1.3
>
> Attachments: 4436-1.0.txt, 4436-1.1.txt, increments.cql.gz
>
>
> Similar to #3821. but affecting normal columns.
> Set up a 2-node cluster with rf=2.
> 1. Create a counter column family and increment a 100 keys in loop 5000
> times.
> 2. Then make a rolling restart to cluster.
> 3. Again increment another 5000 times.
> 4. Make a rolling restart to cluster.
> 5. Again increment another 5000 times.
> 6. Make a rolling restart to cluster.
> After step 6 we were able to reproduce bug with bad counter values.
> Expected values were 15 000. Values returned from cluster are higher then
> 15000 + some random number.
> Rolling restarts are done with nodetool drain. Always waiting until second
> node discover its down then kill java process.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira