[
https://issues.apache.org/jira/browse/CASSANDRA-4795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13553647#comment-13553647
]
Sylvain Lebresne commented on CASSANDRA-4795:
---------------------------------------------
On the compaction strategy patch:
* I would move the call to {{validateCompactionOptions}} in
{{CFPropDefs.validate()}}. First because ALTER also need the validation and
putting it in CFPropDefs handles both "for free". And also because there is no
guarantee that {{CFPropDefs.compactionStrategyClass}} won't be {{null}} which I
think is not handled correctly by the patch (and moving things to
{{CFPropDefs.validate()}} makes it easier to deal with).
* We should not only validate that there is no unknown option provided, but we
should also move the validation of the options themselves from the ctors to the
validateOptions method. Also, I'd prefer adding a validateOptions to
AbstractCompactionStrategy to handle the tombstone related option and have
subclasses call that method explicitly rather than handling everything in the
sublcasses.
> replication, compaction, compression? options are not validated
> ---------------------------------------------------------------
>
> Key: CASSANDRA-4795
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4795
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.1.0
> Reporter: Brandon Williams
> Assignee: Dave Brosius
> Priority: Minor
> Fix For: 1.2.1
>
> Attachments: 4795.compaction_strategy.txt,
> 4795.replication_strategy.txt
>
>
> When creating a keyspace and specifying strategy options, you can pass any
> k/v pair you like.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
