[
https://issues.apache.org/jira/browse/CASSANDRA-4795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13560678#comment-13560678
]
Sylvain Lebresne commented on CASSANDRA-4795:
---------------------------------------------
bq. If user supplied compaction strategies derive from these classes
Why? tTe contract of validateOptions would be that it should return a list with
*only* the options it doesn't know about (which is kind of what it is supposed
to do (and does) in your patch already anyway). Thus if a user supplied
compaction derives from an existing one, it would have to either 1) return an
empty map if he wants to ignore on purpose options or 2) call the super class
validateOptions first (which is what Leveled and SizeTiered do with
AbstractStrategy). Of course, in the case where the compaction strategy do not
implement a validateOptions, we should skip the check for invalid options, but
that's no different from what the patch does now.
> replication, compaction, compression? options are not validated
> ---------------------------------------------------------------
>
> Key: CASSANDRA-4795
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4795
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.1.0
> Reporter: Brandon Williams
> Assignee: Dave Brosius
> Priority: Minor
> Fix For: 1.2.1
>
> Attachments: 4795.compaction_strategy.txt,
> 4795_compaction_strategy_v2.txt, 4795.replication_strategy.txt
>
>
> When creating a keyspace and specifying strategy options, you can pass any
> k/v pair you like.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
