[
https://issues.apache.org/jira/browse/CASSANDRA-5172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sylvain Lebresne updated CASSANDRA-5172:
----------------------------------------
Attachment: 5172-2.txt
Since I forgot to close this issue, I think we can do a little bit better in
fact. The "default" of version 1 (that was committed, so v2 in on top of v1) is
that if a CQL3 client was updated to Cassandra 1.2.0 but without removing the
call to set_cql_version (which wouldn't be surprising since we said nowhere it
should be removed), then this client will have to be changed again with the v1
of this ticket (for no good reason). Besides, making the call to
set_cql_version invalid is not particularly intuitive.
So v2 is a bit more permissive and let people call set_cql_version or not, but
if they call it (which old, non-upgraded CQL3 client will do), then we warn if
a CQL2 method is called.
> Detect (and warn) unintentional use of the cql2 thrift methods when cql3 was
> the intention
> -------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-5172
> URL: https://issues.apache.org/jira/browse/CASSANDRA-5172
> Project: Cassandra
> Issue Type: Improvement
> Affects Versions: 1.2.0
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Priority: Minor
> Fix For: 1.2.1
>
> Attachments: 5172-2.txt, 5172.txt
>
>
> In 1.2.0 we've separated the thrift methods for CQL2 and CQL3 (due to
> CASSANDRA-4734). In doing so, we've made set_cql_version a silent no-op.
> However it means that the 1.1 way of querying CQL3 now silently end up
> calling CQL2 in 1.2.0. So I suggest that if someone calls set_cql_version, we
> record the version set and warn if (throw an invalid exception) if someone
> asks for CQL3 but later use the CQL2 methods.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
