[ 
https://issues.apache.org/jira/browse/CASSANDRA-5314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13663245#comment-13663245
 ] 

Aleksey Yeschenko commented on CASSANDRA-5314:
----------------------------------------------

bq. Why do we add this?

It's the CQL3 row marker. Technically we don't have to do this, but it's just 
the right way to do it and I would sleep better with it in place. Could prevent 
something like CASSANDRA-5572 from happening again in the future (although it's 
true that we only remove the whole rows in the batchlog so the probability of 
something like this is low).

bq. Nit: CopyOnWriteArraySet is a bit of an odd choice, since we expect to 
mutate it once for each entry.

It's mostly irrelevant here - just used the first thread-safe set that came to 
mind.
                
> Replaying old batches can 'undo' deletes
> ----------------------------------------
>
>                 Key: CASSANDRA-5314
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5314
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 1.2.0
>            Reporter: Aleksey Yeschenko
>            Assignee: Aleksey Yeschenko
>             Fix For: 1.2.6
>
>
> Batchlog manager does not subtract the time spent in the batchlog from hints' 
> ttls and this may cause undoing deletes. The attached patch fixes it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to