[
https://issues.apache.org/jira/browse/CASSANDRA-5483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13924053#comment-13924053
]
Lyuben Todorov commented on CASSANDRA-5483:
-------------------------------------------
Patch is almost there, I'm mostly worried about the performance hit we would be
taking by [switching
from|https://github.com/lyubent/cassandra/commit/b2a2f0c6c7b1bc7bed5e10afd54fb9f95d1886b0#diff-e58f1647e24896cbfb4358bee924cf60L99]
{{Executors#newCachedThreadPool}} to {{DebuggableThreadPoolExecutor}}. /cc
[~yukim]
Also there are a few codestyle nits:
# Validator#run has a
[statement|https://github.com/lyubent/cassandra/commit/b2a2f0c6c7b1bc7bed5e10afd54fb9f95d1886b0#diff-05a4a919124ba0d2f176466182c67bb6R254]
with { on the same line.
# Tracing#getCommandName has its { on the same line
Lastsly I created a [feature
branch|https://github.com/lyubent/cassandra/commit/b2a2f0c6c7b1bc7bed5e10afd54fb9f95d1886b0#diff-e58f1647e24896cbfb4358bee924cf60L99]
to simplify applying patches :)
> Repair tracing
> --------------
>
> Key: CASSANDRA-5483
> URL: https://issues.apache.org/jira/browse/CASSANDRA-5483
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Yuki Morishita
> Assignee: Ben Chan
> Priority: Minor
> Labels: repair
> Attachments: 5483-v06-04-Allow-tracing-ttl-to-be-configured.patch,
> 5483-v06-05-Add-a-command-column-to-system_traces.events.patch,
> 5483-v06-06-Fix-interruption-in-tracestate-propagation.patch,
> ccm-repair-test, test-5483-system_traces-events.txt,
> trunk@4620823-5483-v02-0001-Trace-filtering-and-tracestate-propagation.patch,
> trunk@4620823-5483-v02-0002-Put-a-few-traces-parallel-to-the-repair-logging.patch,
> tr...@8ebeee1-5483-v01-001-trace-filtering-and-tracestate-propagation.txt,
> [email protected],
> v02p02-5483-v03-0003-Make-repair-tracing-controllable-via-nodetool.patch,
> v02p02-5483-v04-0003-This-time-use-an-EnumSet-to-pass-boolean-repair-options.patch,
> v02p02-5483-v05-0003-Use-long-instead-of-EnumSet-to-work-with-JMX.patch
>
>
> I think it would be nice to log repair stats and results like query tracing
> stores traces to system keyspace. With it, you don't have to lookup each log
> file to see what was the status and how it performed the repair you invoked.
> Instead, you can query the repair log with session ID to see the state and
> stats of all nodes involved in that repair session.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
