[
https://issues.apache.org/jira/browse/CASSANDRA-5483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13930861#comment-13930861
]
Ben Chan commented on CASSANDRA-5483:
-------------------------------------
Okay, final set of changes (I think).
repro code:
{noformat}
#git checkout 5483
W=https://issues.apache.org/jira/secure/attachment
for url in \
$W/12633989/5483-v07-07-Better-constructor-parameters-for-DebuggableThreadPoolExecutor.patch
\
$W/12633990/5483-v07-08-Fix-brace-style.patch \
$W/12633991/5483-v07-09-Add-trace-option-to-a-more-complete-set-of-repair-functions.patch
\
$W/12633992/5483-v07-10-Correct-name-of-boolean-repairedAt-to-fullRepair.patch
do [ -e $(basename $url) ] || curl -sO $url; done &&
git apply 5483-v07-*.patch &&
ant clean && ant
./ccm-repair-test
{noformat}
Comments:
* {{v07-07}} I get multiple {{RepairJobTask:...}} ids in the trace, so
hopefully this resolves the issue. This is as much as I can say with any
assurance, since I don't normally work with threading.
* {{v07-09}} Without having to worry about backwards compatibility, I decided
to trace-enable all repair functions I could find and conveniently convert. No
real change functionally, since nothing in the source tree calls those
functions and/or overloadings (otherwise I would have had to change much more
in order to get things to compile).
* {{v07-10}} Again, no functional change. I noticed the difference in parameter
name when doing the conversion.
You can take or leave the last two; they don't do anything, really.
> Repair tracing
> --------------
>
> Key: CASSANDRA-5483
> URL: https://issues.apache.org/jira/browse/CASSANDRA-5483
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Yuki Morishita
> Assignee: Ben Chan
> Priority: Minor
> Labels: repair
> Attachments: 5483-v06-04-Allow-tracing-ttl-to-be-configured.patch,
> 5483-v06-05-Add-a-command-column-to-system_traces.events.patch,
> 5483-v06-06-Fix-interruption-in-tracestate-propagation.patch,
> 5483-v07-07-Better-constructor-parameters-for-DebuggableThreadPoolExecutor.patch,
> 5483-v07-08-Fix-brace-style.patch,
> 5483-v07-09-Add-trace-option-to-a-more-complete-set-of-repair-functions.patch,
> 5483-v07-10-Correct-name-of-boolean-repairedAt-to-fullRepair.patch,
> ccm-repair-test, test-5483-system_traces-events.txt,
> trunk@4620823-5483-v02-0001-Trace-filtering-and-tracestate-propagation.patch,
> trunk@4620823-5483-v02-0002-Put-a-few-traces-parallel-to-the-repair-logging.patch,
> tr...@8ebeee1-5483-v01-001-trace-filtering-and-tracestate-propagation.txt,
> [email protected],
> v02p02-5483-v03-0003-Make-repair-tracing-controllable-via-nodetool.patch,
> v02p02-5483-v04-0003-This-time-use-an-EnumSet-to-pass-boolean-repair-options.patch,
> v02p02-5483-v05-0003-Use-long-instead-of-EnumSet-to-work-with-JMX.patch
>
>
> I think it would be nice to log repair stats and results like query tracing
> stores traces to system keyspace. With it, you don't have to lookup each log
> file to see what was the status and how it performed the repair you invoked.
> Instead, you can query the repair log with session ID to see the state and
> stats of all nodes involved in that repair session.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
