[
https://issues.apache.org/jira/browse/CASSANDRA-6895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13941824#comment-13941824
]
Edward Capriolo commented on CASSANDRA-6895:
--------------------------------------------
Btw I did not open this issue to bikeshed with you. It is my opinion as to what
could improve the code base. I looked up the definition of bikeshed and I do
agree it is a trivial change that we do not have to make. To me that does not
mean we should not make it. If every called of a method does the same bit of
code after, that bit of code should probably be inside said method.
I won't open the issue again, one day if someone else trips over this and wants
to change it I will call them a bikeshedder.
> ArrayBackedSortedColumns removeInternal should update sortedsize
> ----------------------------------------------------------------
>
> Key: CASSANDRA-6895
> URL: https://issues.apache.org/jira/browse/CASSANDRA-6895
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Edward Capriolo
> Assignee: Edward Capriolo
> Priority: Minor
>
> I was trying to use ArrayBackedblabla directly and I noticed that while
> internalAdd updates the sorted size internal remove does not.
> https://github.com/edwardcapriolo/cassandra/compare/ArrayBackBackToCali?expand=1
--
This message was sent by Atlassian JIRA
(v6.2#6252)
