[ 
https://issues.apache.org/jira/browse/CASSANDRA-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14018301#comment-14018301
 ] 

Benedict commented on CASSANDRA-6572:
-------------------------------------

* You need to move the getAndSet() on line 76 back inside the if statement
* recycleQueue souldn't compareAndSet its position to zero, it should just set 
it always, and always recycle
* I'd probably make a static helper method for checking if a keyspace is one we 
want to avoid tracing

Otherwise this batch of changes LGTM

> Workload recording / playback
> -----------------------------
>
>                 Key: CASSANDRA-6572
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6572
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core, Tools
>            Reporter: Jonathan Ellis
>            Assignee: Lyuben Todorov
>             Fix For: 2.1.1
>
>         Attachments: 6572-trunk.diff
>
>
> "Write sample mode" gets us part way to testing new versions against a real 
> world workload, but we need an easy way to test the query side as well.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to