[ 
https://issues.apache.org/jira/browse/CASSANDRA-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14041042#comment-14041042
 ] 

Joshua McKenzie commented on CASSANDRA-7398:
--------------------------------------------

Just to distill and re-state what we're trying to accomplish here:  Java needs 
"file:///" in the cassandra.config param (on all platforms from my testing 
locally) and we don't want users to see the message "Cannot locate <blah>" if 
the problem is a missing prefix as that's misleading.  There's also talk of 
automatically prepending this for them.

IMO we're adding an unnecessary amount of complexity to provide a small bit of 
flexibility in user configuration environments here; it would be far simpler to 
tweak our exception handling in YamlConfigurationLoader.getStorageConfigURL, 
string compare for "file:///" on the start of their provided cassandra.config 
param, print out a warning if it's missing, and fail to start the server.

Along with that, the v8 patch looks to have hard-coded paths to your user 
account in the unit tests:
{code:title=hard-coded}
+    @Test
+    @Ignore
+    public void testLoadConfigInValidInputBackSlashes()
+    {
+        System.setProperty("cassandra.config", 
"C:\\Users\\marcoavilac\\Documents\\cassandra\\cassandra\\conf\\cassandra.yaml");
{code}

> Using the -Dcassandra.config VM param needs a "file:///" prefix for the 
> supplied URL
> ------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-7398
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7398
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>         Environment:  Cassandra 2.1.0-rc1-SNAPSHOT, Win 7
>            Reporter: Marco Tulio Avila Cerón
>            Assignee: Marco Tulio Avila Cerón
>            Priority: Minor
>              Labels: lhf, patch
>             Fix For: 2.1 rc2
>
>         Attachments: CASSANDRA-7398_prefix_v2.patch, 
> CASSANDRA-7398_prefix_v3.patch, CASSANDRA-7398_prefix_v4.patch, 
> trunk-7398_v5.txt, trunk-7398_v6.txt, trunk-7398_v7.txt, trunk-7398_v8.txt, 
> trunk-7398_v8_impl.txt, trunk-7398_v8_test.txt
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> The parameter in the VM options -Dcassandra.config= needs file:///
> Allow the user to have optional "file:///" when loading the config file from 
> the filesystem



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to