[
https://issues.apache.org/jira/browse/CASSANDRA-7125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14051143#comment-14051143
]
Benedict commented on CASSANDRA-7125:
-------------------------------------
Thanks for taking a look [[email protected]]
bq. is the changes to CommitLogSegment.recycle needed?
You're right, that changes made it into 2.0 in another CL related ticket, and
was missed when merging into 2.1; I wanted to sneak it in here while we were
changing the CL anyway. I can remove it if you'd prefer and file separately.
bq. CommitLogDescriptor changes is not needed too (as the scoping was right
earlier).
It's necessary for testing. I'll add an \@VisibleForTesting annotation
bq. CassandraDaemon changes might also be not needed since we print the warn
statement and exit out with a stack trace.
I wanted to give users some immediate info about how they can correct the
problem, which a stack trace doesn't do. We could encapsulate this inside of
CommitLogReplayer though, which might be better.
> Fail to start by default if Commit Log fails to validate any messages
> ---------------------------------------------------------------------
>
> Key: CASSANDRA-7125
> URL: https://issues.apache.org/jira/browse/CASSANDRA-7125
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Benedict
> Assignee: Benedict
> Priority: Minor
> Labels: correctness
> Fix For: 2.1.1
>
>
> Current behaviour can be pretty dangerous, and also has a tendency to mask
> bugs during development. We should change the behaviour to default to failure
> if anything unexpected happens, and introduce a cassandra.yaml option that
> permits overriding the default behaviour.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
