[
https://issues.apache.org/jira/browse/CASSANDRA-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14066230#comment-14066230
]
Benedict commented on CASSANDRA-6572:
-------------------------------------
A few brief comments:
# bb.limit() is probably not what you want to be calling; bb.remaining() tells
you how many bytes there are to read in the provided BB
# you appear to be allocating an empty byte[] and not writing anything to it,
however this is an unnecessary step. you can call
variableClone.put(bb.duplicate())
# You don't appear to be doing anything with variablesClone? maybe redundant
dead code you forgot to remove?
# I would avoid calling duplicate() into varsClone; I would simply pass in the
original vars, and call duplicate() when you use them inside of append()
> Workload recording / playback
> -----------------------------
>
> Key: CASSANDRA-6572
> URL: https://issues.apache.org/jira/browse/CASSANDRA-6572
> Project: Cassandra
> Issue Type: New Feature
> Components: Core, Tools
> Reporter: Jonathan Ellis
> Assignee: Lyuben Todorov
> Fix For: 2.1.1
>
> Attachments: 6572-trunk.diff
>
>
> "Write sample mode" gets us part way to testing new versions against a real
> world workload, but we need an easy way to test the query side as well.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
