[
https://issues.apache.org/jira/browse/CASSANDRA-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14072111#comment-14072111
]
Tyler Hobbs commented on CASSANDRA-7590:
----------------------------------------
Review comments:
* You shouldn't remove the overridden {{columnFamily()}} method, because the
version if CFStatement doesn't work for DropIndexStatement (the column family
isn't known until we look it up by index name)
* I don't understand the ConfigurationException. Why isn't the check at the
bottom of {{findIndexedCF()}} throwing an IRE before it gets there?
(Regardless, you want to throw an IRE instead of a ConfigurationException.)
* Can you make sure error messages say "table" instead of "column family"?
There's another use of "column families" in DropIndexStatement that can be
fixed as well.
Besides that, I noticed that the we're erroneously returning schema change
events (and pushing them to drivers) when {{IF \[NOT\] EXISTS}} is used and the
operation is a no-op. I'll open a separate ticket for that.
> java.lang.AssertionError when using DROP INDEX IF EXISTS on non-existing index
> ------------------------------------------------------------------------------
>
> Key: CASSANDRA-7590
> URL: https://issues.apache.org/jira/browse/CASSANDRA-7590
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Hanh Dang
> Assignee: Robert Stupp
> Priority: Minor
> Labels: cql
> Fix For: 2.1.0
>
> Attachments: 7590-drop-index-npe-assert.txt
>
>
> To reproduce:
> cqlsh> CREATE KEYSPACE test WITH REPLICATION = {'class':'SimpleStrategy',
> 'replication_factor':1};
> cqlsh> USE test;
> cqlsh:test> DROP INDEX IF EXISTS fake_index;
> <ErrorMessage code=0000 [Server error] message="java.lang.AssertionError">
--
This message was sent by Atlassian JIRA
(v6.2#6252)
