gfphoenix78 commented on code in PR #709:
URL: https://github.com/apache/cloudberry/pull/709#discussion_r1858044286
##########
src/backend/commands/tag.c:
##########
@@ -471,7 +471,8 @@ AddTagDescriptions(List *tags,
bool isnull;
List *allowed_values;
ListCell *value_cell;
-
+
+ value_cell = NULL;
Review Comment:
I prefer not to check the value of `value_cell` after the loop ends. It
looks a black macro that the cell value is not necessarily null after the loop
normally ends. It will be more robust to use a flag here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
