reshke commented on code in PR #709:
URL: https://github.com/apache/cloudberry/pull/709#discussion_r1846063999
##########
src/backend/commands/tag.c:
##########
@@ -504,7 +504,7 @@ AddTagDescriptions(List *tags,
}
}
- if (value_cell || isnull)
+ if (isnull)
Review Comment:
I don't understand. Value_cell is only set to something under isnull = false.
With initializing value_cell = NULL condition essentially becomes true ||
isnull
Am i right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
