edespino commented on code in PR #731: URL: https://github.com/apache/cloudberry/pull/731#discussion_r1858063693
########## gpMgmt/bin/gpload_test/gpload2/query37.ans: ########## @@ -1,4 +1,4 @@ -NOTICE: Table doesn't have 'DISTRIBUTED BY' clause -- Using column named 's1' as the Cloudberry Database data distribution key for this table. +NOTICE: Table doesn't have 'DISTRIBUTED BY' clause -- Using column named 's1' as the Apache Cloudberry data distribution key for this table. Review Comment: > I think we shouldn't change the message from code (*.c, python, bin and etc) files, this will introduce many file diffs which are pointless. And the worse is, any databases like our commercial ones or tools based on CBDB would fail on CI due to that and have to fix them. Rename the DOC part is enough. `Cloudberry Database` doesn't have conflict with `Apache Cloudberry ` I tend to agree with @avamingli . However, there are several important user facing changes which would be appropriate to make. Like that in `configure.ac` which go into `version()`. There are also user facing help content we should consider making. This is not an easy task but it has to be performed on some level. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
