my-ship-it commented on code in PR #8:
URL: https://github.com/apache/cloudberry-gpbackup/pull/8#discussion_r1865158762


##########
report/report.go:
##########
@@ -298,8 +297,8 @@ func EnsureBackupVersionCompatibility(backupVersion string, 
restoreVersion strin
        restoreSemVer, err := semver.Make(restoreVersion)
        gplog.FatalOnError(err)
        if backupSemVer.GT(restoreSemVer) {
-               gplog.Fatal(errors.Errorf("gprestore %s cannot restore a backup 
taken with gpbackup %s; please use gprestore %s or later.",
-                       restoreVersion, backupVersion, backupVersion), "")
+               gplog.Warn("gprestore %s cannot restore a backup taken with 
gpbackup %s; please use gprestore %s or later.",

Review Comment:
   Generally speaking, gpbackup is mainly used for database backup, not for 
upgrading, because different versions may have potential data compatibility 
issues.
   If upgrading is needed, it is recommended to use other approaches.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to