xanadu-dev commented on code in PR #8:
URL: https://github.com/apache/cloudberry-gpbackup/pull/8#discussion_r1865515318
##########
report/report.go:
##########
@@ -298,8 +297,8 @@ func EnsureBackupVersionCompatibility(backupVersion string,
restoreVersion strin
restoreSemVer, err := semver.Make(restoreVersion)
gplog.FatalOnError(err)
if backupSemVer.GT(restoreSemVer) {
- gplog.Fatal(errors.Errorf("gprestore %s cannot restore a backup
taken with gpbackup %s; please use gprestore %s or later.",
- restoreVersion, backupVersion, backupVersion), "")
+ gplog.Warn("gprestore %s cannot restore a backup taken with
gpbackup %s; please use gprestore %s or later.",
Review Comment:
The problem I have is that I have not yet found any reference to "other
approaches" for the greenplum to cloudberry transition and in my case this
approach worked and enabled me to continue evaluation of cloudberry-db.
I can see why this PR cannot be accepted but the simplest solution I
suggested earlier would be to change the versioning so that gpbackup could be
used without any changes for importing greenplum data to cloudberry
> One simple solution would be if the Cloudberry Gpbackup/Gprestore
versioning started at version 2.X - then if trying to restore backup data from
Greenplum to Cloudberry during a migration then checks would succeed as the
Cloudberry version is later than the Greenplum version 1.X.
> Even if the process is not fully supported then it provides a means of
migration to CloudberryDB - without making such a change I cannot see any
practical way of migrating and we will remain using Greenplum
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
