zhangyue-hashdata commented on code in PR #724:
URL: https://github.com/apache/cloudberry/pull/724#discussion_r1869418850
##########
src/backend/executor/nodeSeqscan.c:
##########
@@ -87,8 +101,17 @@ SeqNext(SeqScanState *node)
/*
* get the next tuple from the table
*/
- if (table_scan_getnextslot(scandesc, direction, slot))
+ while (table_scan_getnextslot(scandesc, direction, slot))
+ {
+ if (TupIsNull(slot))
+ return slot;
+
+ if (node->filter_in_seqscan && node->filters &&
+ !PassByBloomFilter(node, slot))
Review Comment:
Yes, when creating the Bloom filter, the system evaluates the estimated
number of rows that this hash join will process and the amount of available
memory during the execution plan generation. It determines whether using a
Bloom filter for filtering data would be effective based on this evaluation. If
it is assessed that the Bloom filter would not sufficiently enhance
performance, then the Bloom filter will not be created.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
