Re: [PR] Push the runtime filter from HashJoin down to SeqScan or AM. [cloudberry]

Thu, 05 Dec 2024 06:55:47 -0800 


zhangyue-hashdata commented on PR #724:
URL: https://github.com/apache/cloudberry/pull/724#issuecomment-2520542895

   > Hi, with gp_enable_runtime_filter_pushdown = on, execute SQL below will 
get a crash:
   > 
   > ```sql
   > gpadmin=# show gp_enable_runtime_filter_pushdown;
   >  gp_enable_runtime_filter_pushdown
   > -----------------------------------
   >  on
   > (1 row)
   > ```
   > 
   > ```sql
   > CREATE TABLE test_tablesample (dist int, id int, name text) WITH 
(fillfactor=10) DISTRIBUTED BY (dist);
   > -- use fillfactor so we don't have to load too much data to get multiple 
pages
   > 
   > -- Changed the column length in order to match the expected results based 
on relation's blocksz
   > INSERT INTO test_tablesample SELECT 0, i, repeat(i::text, 875) FROM 
generate_series(0, 9) s(i) ORDER BY i;
   > INSERT INTO test_tablesample SELECT 3, i, repeat(i::text, 875) FROM 
generate_series(10, 19) s(i) ORDER BY i;
   > INSERT INTO test_tablesample SELECT 5, i, repeat(i::text, 875) FROM 
generate_series(20, 29) s(i) ORDER BY i;
   > EXPLAIN (COSTS OFF)
   >   SELECT id FROM test_tablesample TABLESAMPLE SYSTEM (50) REPEATABLE (2);
   > FATAL:  Unexpected internal error (assert.c:48)
   > DETAIL:  FailedAssertion("IsA(planstate, SeqScanState)", File: 
"explain.c", Line: 4154)
   > server closed the connection unexpectedly
   >         This probably means the server terminated abnormally
   >         before or while processing the request.
   > The connection to the server was lost. Attempting reset: Succeeded.
   > psql (14.4, server 14.4)
   > ```
   > 
   > <img alt="image" width="1779" 
src="https://private-user-images.githubusercontent.com/17311022/392676960-a8882208-1800-4df3-9f2d-7c659e24aaa3.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzM0MTAzMTUsIm5iZiI6MTczMzQxMDAxNSwicGF0aCI6Ii8xNzMxMTAyMi8zOTI2NzY5NjAtYTg4ODIyMDgtMTgwMC00ZGYzLTlmMmQtN2M2NTllMjRhYWEzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDEyMDUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQxMjA1VDE0NDY1NVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWRhYzExMjYyNmM3MTllZGExNWJhMmZhNjRiZjYwODg4MmY3YTVlMjcyZjYxMjg2YzVkZmM1MmY4OTNlZWQxNTgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.inCY4gvv-RdOzeQPxitJ7obOz2FFpSMeYCgWzrERhS0";>
   
   hanks for your test case. I fix it in 
https://github.com/apache/cloudberry/commit/98dac6dfc7d5e44e111aa16bdf5948d07ee2eb00
 And add the test case into gp_runtime_filter.sql too.
   fix in 
https://github.com/apache/cloudberry/commit/98dac6dfc7d5e44e111aa16bdf5948d07ee2eb00


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to