yjhjstz commented on code in PR #724:
URL: https://github.com/apache/cloudberry/pull/724#discussion_r1879796311
##########
src/backend/executor/nodeSeqscan.c:
##########
@@ -87,8 +101,14 @@ SeqNext(SeqScanState *node)
/*
* get the next tuple from the table
*/
- if (table_scan_getnextslot(scandesc, direction, slot))
+ while (table_scan_getnextslot(scandesc, direction, slot))
+ {
+ if (node->filter_in_seqscan && node->filters &&
Review Comment:
```c++
if (!node->filter_in_seqscan || !node->filters)
{
if (table_scan_getnextslot(scandesc, direction, slot))
return slot;
}
else
{
while (table_scan_getnextslot(scandesc, direction, slot))
{
.....
}
}
```
this make origin path more efficient and readable ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
