ZTE-EBASE commented on code in PR #1226: URL: https://github.com/apache/cloudberry/pull/1226#discussion_r2206084485
########## src/backend/utils/misc/fstream/gfile.c: ########## @@ -40,6 +40,11 @@ #include <sys/file.h> /* for flock */ #include <unistd.h> +#include <libssh2.h> Review Comment: It doesn't seem quite appropriate to set a macro every time a dependency is introduced. Moreover, it can be seen from the code I submitted that the logic using the libssh2 library functions is all based on judging the SFTP protocol method, and it won't have any impact on the existing code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
